Skip to content

feat(vertexai): support lyria models#267

Draft
CorieW wants to merge 5 commits into
genkit-ai:mainfrom
invertase:vertexai-add-lyria
Draft

feat(vertexai): support lyria models#267
CorieW wants to merge 5 commits into
genkit-ai:mainfrom
invertase:vertexai-add-lyria

Conversation

@CorieW

@CorieW CorieW commented Apr 28, 2026

Copy link
Copy Markdown
Member

Support Lyria models in VertexAI plugin.

Testing

Screenshot 2026-04-28 at 13 00 43 image

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for Lyria models in the Vertex AI plugin. It includes the implementation of the Lyria model logic, supporting both the predict and interactions endpoints, along with necessary API client updates and unit tests. Feedback highlights that the media input handling incorrectly defaults to image types and that the interactions API client hardcodes the global location, potentially ignoring user configuration.

Comment thread packages/genkit_vertexai/lib/src/lyria.dart
Comment thread packages/genkit_vertexai/lib/src/vertex_api_client.dart
@CorieW

CorieW commented May 10, 2026

Copy link
Copy Markdown
Member Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for Lyria models in the Vertex AI plugin, including a new interactions API endpoint and LyriaOptions for configuration. It implements the logic to handle both standard and interaction-based model requests and includes comprehensive tests. A review comment identified a potential runtime error where a nullable request object is force-unwrapped, suggesting a safer null check.

Comment thread packages/genkit_vertexai/lib/src/lyria.dart Outdated
@cabljac cabljac self-requested a review May 29, 2026 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants