Skip to content

feat(vertexai): tuned models (endpoints/YOUR_ENDPOINT_ID)#268

Draft
CorieW wants to merge 7 commits into
genkit-ai:mainfrom
invertase:vertexai-add-tuned-models
Draft

feat(vertexai): tuned models (endpoints/YOUR_ENDPOINT_ID)#268
CorieW wants to merge 7 commits into
genkit-ai:mainfrom
invertase:vertexai-add-tuned-models

Conversation

@CorieW

@CorieW CorieW commented Apr 28, 2026

Copy link
Copy Markdown
Member

This pull request adds support for Vertex AI tuned models (custom endpoints) in the genkit_vertexai package, allowing users to call models deployed to Vertex AI endpoints. It introduces new methods for creating and resolving tuned model actions, refactors API client creation for flexibility, and includes tests to validate the new functionality.

Testing

image

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for tuned models in the Vertex AI plugin by introducing a tunedModel method and updating the API client to handle endpoint-specific requests. The review correctly identifies that the validation and URI encoding logic for project IDs and locations is duplicated across multiple methods, suggesting a refactor to centralize this logic within _createVertexApiClient to improve maintainability.

Comment thread packages/genkit_vertexai/lib/src/vertex_api_client.dart
@cabljac cabljac self-requested a review May 29, 2026 10:27
Comment thread packages/genkit_vertexai/lib/src/vertex_api_client.dart Outdated
Comment thread packages/genkit_google_genai/lib/src/common_plugin.dart Outdated
Comment thread packages/genkit_google_genai/lib/src/common_plugin.dart Outdated
@CorieW

CorieW commented Jun 2, 2026

Copy link
Copy Markdown
Member Author
  • Tested changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants