feat(vertexai): tuned models (endpoints/YOUR_ENDPOINT_ID)#268
Draft
CorieW wants to merge 7 commits into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds support for tuned models in the Vertex AI plugin by introducing a tunedModel method and updating the API client to handle endpoint-specific requests. The review correctly identifies that the validation and URI encoding logic for project IDs and locations is duplicated across multiple methods, suggesting a refactor to centralize this logic within _createVertexApiClient to improve maintainability.
cabljac
reviewed
May 29, 2026
cabljac
reviewed
May 29, 2026
cabljac
reviewed
May 29, 2026
Member
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for Vertex AI tuned models (custom endpoints) in the
genkit_vertexaipackage, allowing users to call models deployed to Vertex AI endpoints. It introduces new methods for creating and resolving tuned model actions, refactors API client creation for flexibility, and includes tests to validate the new functionality.Testing