193: Output cleanup, help discoverability, and footer rewrite#139
193: Output cleanup, help discoverability, and footer rewrite#139
Conversation
Add quickstart block and skills tip to `list` output. Route `list skill`, `list enrich`, `list batch`. Document --biomarker (trial) and --since (article). Expand phenotype/gwas pages with workflow tips. Add conditional Affects column to health output when APIs are unhealthy.
…lean templates - BUG-11: Remove triple-rendered population data; single indented KV list - BUG-12: Convert pipe tables to KV pairs (conservation, AlphaGenome, interactions) and bullet lists (adverse event reactions/outcomes) - BUG-13: Standardize metadata headers to plain Key: Value (no bold) - BUG-09: Sections footer now shows copy-pasteable biomcp get commands - BUG-10: Related footer now shows full biomcp commands under See also: - Update docs with gene helpers and variant trials helper
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8d013249fa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
src/render/markdown.rs
Outdated
| vec![format!("reports {device}"), "recalls class-i".to_string()] | ||
| vec![ | ||
| format!("biomcp search adverse-event --type device --device {device}"), | ||
| "biomcp search adverse-event --type recall --classification class-i".to_string(), |
There was a problem hiding this comment.
Emit valid recall classification in device-event footer command
The new related_device_event footer command uses --classification class-i, but recall classification normalization only accepts Class I/II/III (or 1/2/3), so this copy-paste command now fails with an invalid-argument error instead of running. This directly breaks the new “See also” workflow for every device-event card that includes the recall suggestion.
Useful? React with 👍 / 👎.
src/render/markdown.rs
Outdated
| } | ||
|
|
||
| vec![format!("drugs {id}")] | ||
| vec![format!("biomcp search drug {id}")] |
There was a problem hiding this comment.
Use pathway helper for pathway-related drug suggestion
This footer now suggests biomcp search drug <pathway-id>, which goes through the generic drug free-text query path (search drug) instead of the pathway-specific traversal (pathway drugs) intended for Reactome IDs. For IDs like R-HSA-..., the suggested command is usually irrelevant or empty, so users lose the expected pathway→drug pivot from the related-command block.
Useful? React with 👍 / 👎.
…lper - related_device_event: use "Class I" (not class-i) for valid normalization - related_pathway: use `pathway drugs` helper (not `search drug` free-text)
Summary
list skillalias,list enrich/list batchpages,--biomarker/--sincedocs, expanded phenotype/gwas pages, health impact visibilityKey: ValueSections:→More:with copy-pasteablebiomcp getcommands;Related:→See also:with full commandsVerification
cargo test: 349/349cargo clippy -D warnings: 0 warningsdocs/biomcp-cli/: 375/376 (1 pre-existing CI trigger contract)