Skip to content

193: Output cleanup, help discoverability, and footer rewrite#139

Merged
imaurer merged 4 commits intomainfrom
193-biomcp-help-fixes
Mar 2, 2026
Merged

193: Output cleanup, help discoverability, and footer rewrite#139
imaurer merged 4 commits intomainfrom
193-biomcp-help-fixes

Conversation

@imaurer
Copy link
Collaborator

@imaurer imaurer commented Mar 2, 2026

Summary

  • Help discoverability: Quickstart block, skills tip, list skill alias, list enrich/list batch pages, --biomarker/--since docs, expanded phenotype/gwas pages, health impact visibility
  • Output dedup (BUG-11): Population data shown once instead of 3x — pipe table replaced with indented key-value pairs
  • Template cleanup (BUG-12/13): Conservation, AlphaGenome, interactions converted from pipe tables to KV pairs; adverse event reactions/outcomes to bullet lists; metadata headers standardized to plain Key: Value
  • Footer rewrite (BUG-09/10): Sections:More: with copy-pasteable biomcp get commands; Related:See also: with full commands
  • Version bump to 0.8.7

Verification

  • Architect signoff: APPROVED
  • cargo test: 349/349
  • cargo clippy -D warnings: 0 warnings
  • VV docs/biomcp-cli/: 375/376 (1 pre-existing CI trigger contract)
  • See signoff.md for full details

Add quickstart block and skills tip to `list` output. Route `list skill`,
`list enrich`, `list batch`. Document --biomarker (trial) and --since
(article). Expand phenotype/gwas pages with workflow tips. Add conditional
Affects column to health output when APIs are unhealthy.
…lean templates

- BUG-11: Remove triple-rendered population data; single indented KV list
- BUG-12: Convert pipe tables to KV pairs (conservation, AlphaGenome,
  interactions) and bullet lists (adverse event reactions/outcomes)
- BUG-13: Standardize metadata headers to plain Key: Value (no bold)
- BUG-09: Sections footer now shows copy-pasteable biomcp get commands
- BUG-10: Related footer now shows full biomcp commands under See also:
- Update docs with gene helpers and variant trials helper
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8d013249fa

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

vec![format!("reports {device}"), "recalls class-i".to_string()]
vec![
format!("biomcp search adverse-event --type device --device {device}"),
"biomcp search adverse-event --type recall --classification class-i".to_string(),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Emit valid recall classification in device-event footer command

The new related_device_event footer command uses --classification class-i, but recall classification normalization only accepts Class I/II/III (or 1/2/3), so this copy-paste command now fails with an invalid-argument error instead of running. This directly breaks the new “See also” workflow for every device-event card that includes the recall suggestion.

Useful? React with 👍 / 👎.

}

vec![format!("drugs {id}")]
vec![format!("biomcp search drug {id}")]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Use pathway helper for pathway-related drug suggestion

This footer now suggests biomcp search drug <pathway-id>, which goes through the generic drug free-text query path (search drug) instead of the pathway-specific traversal (pathway drugs) intended for Reactome IDs. For IDs like R-HSA-..., the suggested command is usually irrelevant or empty, so users lose the expected pathway→drug pivot from the related-command block.

Useful? React with 👍 / 👎.

…lper

- related_device_event: use "Class I" (not class-i) for valid normalization
- related_pathway: use `pathway drugs` helper (not `search drug` free-text)
@imaurer imaurer merged commit b30d518 into main Mar 2, 2026
2 checks passed
@imaurer imaurer deleted the 193-biomcp-help-fixes branch March 2, 2026 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant