sci-physics/samurai: new package, add 2.1.1 #1340
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
APN-Pucky
commented
Mar 26, 2025
•
APN-Pucky
commented
- test it again
Signed-off-by: Alexander Puck Neuwirth <[email protected]>
Signed-off-by: Alexander Puck Neuwirth <[email protected]>
Comment on lines
33
to
38
| econf FCFLAGS="${FCFLAGS} -std=legacy -fPIC -I${ESYSROOT}/usr/include" \ | ||
| --with-avh_olo="${ESYSROOT}"/usr/$(get_libdir)/libavh_olo.so \ | ||
| --with-avh_olo_precision=double \ | ||
| --with-precision=double \ | ||
| $(use_with qcdloop qcdloop "${ESYSROOT}"/usr) \ | ||
| $(use_with looptools looptools "${ESYSROOT}"/usr) |
There was a problem hiding this comment.
This would look a bit nicer if we'd use a myeconfargs array here instead.
There was a problem hiding this comment.
I think also the default before needs to be removed, since that calls econf already... (Also needs bash...).
Signed-off-by: Alexander Puck Neuwirth <[email protected]>
Signed-off-by: Alexander Puck Neuwirth <[email protected]>
Signed-off-by: Alexander Puck Neuwirth <[email protected]>
Nowa-Ammerlaan
approved these changes
Mar 26, 2025
APN-Pucky
commented
Mar 26, 2025
| --with-avh_olo="${ESYSROOT}"/usr/$(get_libdir)/libavh_olo.so | ||
| --with-avh_olo_precision=double | ||
| --with-precision=double | ||
| $(use_with qcdloop qcdloop "${ESYSROOT}"/usr) |
There was a problem hiding this comment.
Does this need quotes again in case ESYSROOT has a space? I.e. https://github.com/gentoo/gentoo/blob/f84b09f5dd30d2e41d33afd6c284cc99cd9e22fa/app-admin/sudo/sudo-1.9.16_p2-r1.ebuild#L184 quotes twice.
There was a problem hiding this comment.
Yes it needs (double) quotes, the inside quotes ensure that the ESYSROOT/usr is one argument for use_with, the outside quotes ensures that the ESYSROOT/usr is one single element of the array.
Signed-off-by: Alexander Puck Neuwirth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.