Executor scheduler #514
Open
Executor scheduler #514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # services/Cargo.toml
# Conflicts: # services/src/error.rs
Co-authored-by: Christian Beilschmidt <[email protected]>
# Conflicts: # operators/src/error.rs # services/src/pro/contexts/in_memory.rs
This reverts commit fe648d3.
Restricted Hash and Eq implementation to concrete Key type
# Conflicts: # operators/src/error.rs
… state, i.e., only plots use the executor);
# Conflicts: # services/src/error.rs
…atic result stream. This commit contains implementations for VectorQueryProcessor and RasterQueryProcessor.
# Conflicts: # services/src/error.rs
# Conflicts: # services/src/util/config.rs
# Conflicts: # services/src/error.rs # services/src/util/config.rs
…eating self-referential structs
# Conflicts: # datatypes/src/collections/feature_collection.rs
…or_scheduler # Conflicts: # services/src/error.rs
| debug!("Scheduling tasks."); | ||
| Self::schedule(executor, new_tasks, threshold).await; | ||
| debug!("Finished scheduling tasks."); | ||
| }); |
| /// Schedules the given set of tasks. Merging of tasks is performed, if | ||
| /// the occurring dead space is below the given threshold. | ||
| async fn schedule(executor: Arc<Executor<Desc>>, tasks: TaskMap<Desc>, threshold: f64) { | ||
| let merged_tasks = tokio::task::spawn_blocking(move || Self::merge_tasks(tasks, threshold)) |
There was a problem hiding this comment.
this is already inside a tokio task, why spawn another one?
| } | ||
|
|
||
| /// Merges the tasks with the given threshold | ||
| fn merge_tasks(tasks: TaskMap<Desc>, threshold: f64) -> TaskMap<Desc> { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR outdates PR #419. It contains the executor as well as a proof-of-concept implementation of a task-scheduler.
The scheduler collects tasks (e.g., computation) for a fixed amount of time (e.g., 100ms) and tries to merge multiple small tasks into one bigger task to avoid redundant computations.
This is especially useful if clients request data in a tiled fashion.