Some modification to correct sniff in DIO clearing pullup/pulldown issues #79 #81
+41
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PinService.h, PinService.cpp
- replaced pullupState by pullState which stores the type of the input
- created pulltype to define the possible types of the input
- modified the setInput, setInputPullup. setInputPullDown, togglePullup method so they
update pullState each time the type of the input changes
- added a togglePullDown method
- added a getPullType method which returns the current type of the input
DioController.cpp
- modified handleSniff so that the current state of the pullup/pulldown is preserved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A proposed correction to issue #79
PinService.h, PinService.cpp
- replaced pullupState by pullState which stores the type of the input
- created pulltype to define the possible types of the input
- modified the setInput, setInputPullup. setInputPullDown, togglePullup method so they update pullState each time the type of the input changes
- added a togglePullDown method
- added a getPullType method which returns the current type of the input
DioController.cpp
- modified handleSniff so that the current state of the pullup/pulldown is preserved.