-
Notifications
You must be signed in to change notification settings - Fork 3
Usability: increase PAGE_SIZE
and DEFAULT_PAGE_SIZE
#556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Fixes Usability Issues in current versions of *ArcGIS Pro* and *QGIS* `1000` is a reasonable default page size
@Rdataflow thanks for your PR, unfortunately we have to limit the page size to 100 due to performance reason for the moment. We will need to have a look if we can improve serailization performance in order to increase the limit before changing that. |
@ltshb maybe the following context can help you for your performance consideration:
|
@Rdataflow the issue is unfortunately not in the SQL query which is very fast but in the serialization done by https://www.django-rest-framework.org/ which is very slow. |
@ltshb so maybe it's useful to apply some kind of caching? i.e. whitenoise or wichever CDN cache you can apply for such serialized json, as currently there seems no cache from the response header |
@Rdataflow we already have caching in Cloudfront but caching only works for GET request and would not solve the issue for the search endpoint that uses POST request. We have an internal ticket that will check deeper on what are the actual performance when increasing this value, as the performance that I'm aware off date from the STAC launch a few years ago. We will keep you posted as soon as we have more insight on the performance. Internal ticket is PB-1591 (only accessible by geoadmin team) |
@ltshb perfect caching already works for GET
IIUC it qualifies for caching - but it doesn't (AFAICT from the response header) |
@Rdataflow we cannot increase the limit because of performance reason. However we implemented the item-search conformance and also changed the behavior of the limit query parameter. Now the query parameter returns 200 OK even if the max limit is reached, the service automatically correct the limit to 100. This should help with QGIS. Can you try again and let me know if it helped ? Note this changes is only on the STAC v1 implemented, not in STAC v0.9. |
@ltshb nothing changed. as QGIS doesnt pass no params still only the first page is shown. |
Fixes Usability Issues in current versions of ArcGIS Pro and QGIS
1000
is a reasonable default page sizeIf @geoadmin wants to promote 🚀 the usage of STAC API such usability fixes are no brainer low hanging 😉
and consider M2M is only useful if client facing interfaces work