PB-1403 WIP#642
Draft
adk-swisstopo wants to merge 6 commits into
Draft
Conversation
adk-swisstopo
force-pushed
the
PB-1403-update
branch
11 times, most recently
from
8bca52b to
5eadc43
Compare
We test that the `Expires` header is set correctly in four different scenarios. The code extracting and comparing the header is duplicated four times. This change moves the code into a method which is called in each of the four cases with slightly different parametres. We also simplify the checks to let `assertAlmostEqual` and `assertIn` do the work themselves. This gives us better error messages too.
adk-swisstopo
force-pushed
the
PB-1403-update
branch
3 times, most recently
from
5f1167c to
4678092
Compare
The `auto_variables_triggers` function is used to generate PostgreSQL triggers to update some fields automatically. Currently it is triggered when any field changes. For PB-1403 we want at least one of these triggers to be conditional on specific fields. This change replaces the raw-SQL-based `Condition('OLD.* IS DISTINCT FROM NEW.*')` with `AnyChange(fields)`. This is equivalent as long as `fields` is empty. We also update `auto_variables_triggers` to take a new optional `fields` argument (defaulting to empty). This allows callers to define the conditions that apply for the trigger. A later change will make use of this new parametre.
The `updated` field of `Asset` objects is updated when any field is updated. This causes unecessary churn and confusion when hidden metadata are updated. This change ensures the `updated` field is only updated when the `file`, `checksum_multihash` or `file_size` field is updated. Only update Asset mtime when specific data fields are updated.
adk-swisstopo
force-pushed
the
PB-1403-update
branch
from
4678092 to
313cc91
Compare
adk-swisstopo
force-pushed
the
PB-1403-update
branch
from
313cc91 to
4f12e38
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Experimental branch from which I cherry pick.