PB-1403: only update Item timestamp when Asset timestamp is updated.#649
Open
adk-swisstopo wants to merge 2 commits into
Open
PB-1403: only update Item timestamp when Asset timestamp is updated.#649adk-swisstopo wants to merge 2 commits into
adk-swisstopo wants to merge 2 commits into
Conversation
adk-swisstopo
force-pushed
the
PB-1403-item
branch
from
5577d5e to
4c708e4
Compare
adk-swisstopo
force-pushed
the
PB-1403-item
branch
from
4c708e4 to
3205dec
Compare
The `updated` field of `Item` object is updated whenever any associated `Asset` object is updated. This causes unecessary churn and confusion when hidden metadata are updated. This change ensures the `Item.updated` field is only updated when the `Asset.updated` field is updated.
…more. Only changes to Asset.file or Asset.checksum_multihash trigger a timestamp update now.
adk-swisstopo
force-pushed
the
PB-1403-item
branch
from
30cb563 to
cd41014
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
updatedfield ofItemobject is updated whenever any associatedAssetobject is updated. This causes unecessary churn and confusion when hidden metadata are updated.This change ensures the
Item.updatedfield is only updated when theAsset.updatedfield is updated. This broke a test that assumed that updatingAsset.titlewould updateCollection.updated. I have modified the test to match the new behaviour.