PB-2241: Added labels for v3 of BABS civil signatures ⚠️ don't merge

[hansmannj]

⚠️ Don't merge yet. ⚠️
First we need to test on DEV and unlist the old icon sets via k8s env var configurations.

Test link

[pakb]

that's only labels, we can safely merge that without any issue

[cypress]

web-mapviewer    Run #6528

Run Properties:   Failed #6528  •  9df634aad7: PB-2241: Added labels for v3 of BABS civil signatures

Project	web-mapviewer
Branch Review	feat_PB-2241_new_babs_icon_sets
Run status	Failed #6528
Run duration	09m 04s
Commit	9df634aad7: PB-2241: Added labels for v3 of BABS civil signatures
Committer	Jürgen Hansmann
View all properties for this run ↗︎

---

Test results
Failures	34
Flaky	0
Pending	20
Skipped	2
Passing	225
View all changes introduced in this branch ↗︎

---

Tests for review

  importToolFile.cy.js • 1 failed test • e2e/chrome/mobile

View Output

Test		Artifacts
The Import File Tool > Import KML file		Test Replay Screenshots

  3d/layers.cy.js • 10 failed tests • e2e/chrome/mobile

View Output

Test		Artifacts
Test of layer handling in 3D > add layer from search bar		Test Replay Screenshots
Test of layer handling in 3D > sets the opacity to the value defined in the layers URL param or menu UI		Test Replay Screenshots
Test of layer handling in 3D > sets the timestamp of a layer when specified in the layers URL param		Test Replay Screenshots
Test of layer handling in 3D > reorders visible layers when corresponding buttons are pressed		Test Replay Screenshots
Test of layer handling in 3D > add GeoJson layer with opacity from URL param		Test Replay Screenshots
Test of layer handling in 3D > removes a layer from the visible layers when the "remove" button is pressed		Test Replay Screenshots
Test of layer handling in 3D > uses the 3D configuration of a layer if one exists		Test Replay Screenshots
Test of layer handling in 3D > add KML layer from drawing		Test Replay Screenshots
Test of layer handling in 3D > Verify layer features in 2D and 3D		Test Replay Screenshots
Test of layer handling in 3D > Verify a layer with EPSG:4326(WEBMERCATOR) bounding box in 2D and 3D		Test Replay Screenshots

  legacyParamImport.cy.js • 3 failed tests • e2e/chrome/mobile

View Output

Test		Artifacts
Test on legacy param import > 3D import > transfers camera parameter from legacy URL to the new URL		Test Replay Screenshots
Test on legacy param import > 3D import > transfers camera parameter from legacy URL to the new URL only heading		Test Replay Screenshots
Test on legacy param import > 3D import > transfers camera parameter from legacy URL to the new URL only elevation		Test Replay Screenshots

  geolocation.cy.js • 5 failed tests • e2e/chrome/mobile

View Output

Test		Artifacts
Geolocation cypress > Test geolocation when first time activating it > Prompt the user to authorize geolocation when the geolocation button is clicked for the first time on 3D Map		Test Replay Screenshots
Geolocation cypress > Test geolocation when geolocation is authorized > Doesn't prompt the user if geolocation has previously been authorized on 3D Map		Test Replay Screenshots
Geolocation cypress > Test geolocation when geolocation is failed to be retrieved > shows an error telling the user geolocation is denied on 3D Map		Test Replay Screenshots
Geolocation cypress > Test geolocation when geolocation is failed to be retrieved > shows an alert telling the user geolocation is not able to be retrieved due to time out on 3D Map		Test Replay Screenshots
Geolocation cypress > Test geolocation when geolocation is failed to be retrieved > shows an alert telling the user geolocation is not available for other reason on 3D Map		Test Replay Screenshots

  3d/featureSelection.cy.js • 1 failed test • e2e/chrome/mobile

View Output

Test		Artifacts
Testing the feature selection in 3D > Feature identification on the cesium map > can select features in a WMS and a KML		Test Replay Screenshots

The first 5 failed specs are shown, see all 11 specs in Cypress Cloud.

[hansmannj]

that's only labels, we can safely merge that without any issue

OK, makes sense. So there won't be an error in case the v3 icon set is not yet around, right?

[pakb]

OK, makes sense. So there won't be an error in case the v3 icon set is not yet around, right?

nope, i18n keys are asked on-demand, and if not found shown untranslated.

there are some weird unrelated errors in the CI/e2e tests, so you can force-push the same commit to see if another run could fix this