Bump to edition 2024#1028
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bumps geoarrow-rs to use edition 2024, see https://doc.rust-lang.org/edition-guide/rust-2024/index.html and https://blog.rust-lang.org/2025/02/20/Rust-1.85.0.html. Note that this causes an MSRV bump to rust 1.85.
In general, an MSRV bump to the second most recent rust version wouldn't be acceptable to many stable Rust libraries, but let's face it, geoarrow-rs isn't currently in the category of stable rust library. We can call ourselves bleeding edge for now and take the DX wins of edition 2024. And by the time that geoarrow-rs is more stable (a couple months?) it'll be less of a hurdle to require Rust 1.85 for all users.
The second run (so compile is fully cached) of running
cargo test --all-featuresdropped from 76.52s to 14.26s. And given that we'd like to add more and more doctests, this on its own is a very nice improvement to developer experience.