Skip to content

feat(pyo3-geoarrow): add add_triangle and add_line for BoundingRect#1397

Merged
kylebarron merged 1 commit into
geoarrow:mainfrom
ddupg:feat/box-triangle-line
Nov 21, 2025
Merged

feat(pyo3-geoarrow): add add_triangle and add_line for BoundingRect#1397
kylebarron merged 1 commit into
geoarrow:mainfrom
ddupg:feat/box-triangle-line

Conversation

@ddupg
Copy link
Copy Markdown
Contributor

@ddupg ddupg commented Nov 11, 2025

No description provided.

Change-Id: I1a856903cb1a66d84728fef294187940af6304b6
@github-actions github-actions Bot added the feat label Nov 11, 2025
@kylebarron kylebarron changed the title feat(geoarrow): add add_triangle and add_line for BoundingRect feat(pyo3-geoarrow): add add_triangle and add_line for BoundingRect Nov 21, 2025
@kylebarron
Copy link
Copy Markdown
Member

I've been on vacation and add conferences, hence the slow review. Thanks!

Did you actually hit this todo! panic yourself? I wouldn't have imagined that it would be possible to hit that todo there.

Ideally I'd like to move this bounding rect computation and similar things into a geoarrow-expr-native crate. I'd like to have a place to start assembling utilities that don't fit into geoarrow-array or geoarrow-cast, but that are specified as not having a dependency on geo or geos.

If you're interested you'd be welcome to start creating that crate.

For now I'll merge this though, thanks!

@kylebarron kylebarron merged commit d9d987f into geoarrow:main Nov 21, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants