feat: add additional_instructions parameter to GeoFilterParser#87
Merged
Conversation
zurfjereluhmie
previously approved these changes
Apr 22, 2026
Member
zurfjereluhmie
left a comment
There was a problem hiding this comment.
LGTM, a few minor suggestions below.
Allows callers to inject custom rules (region-specific endonyms, domain aliases, organization-specific place names) as a dedicated system message positioned after the main system prompt and before the few-shot examples, without forking the default prompt.
5e73c8d to
46f892e
Compare
zurfjereluhmie
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows callers to inject custom rules (region-specific endonyms, domain aliases, organization-specific place names) as a dedicated system message positioned after the main system prompt and before the few-shot examples, without forking the default prompt.