Restore react migration - #115
Open
jessisena wants to merge 4 commits into
Open
Conversation
The rollback in #96 was caused by a vite.config.js shadowing vite.config.ts, which broke asset paths and module resolution. That root cause is addressed in the following commit. This restores all 58 files from the React migration. Dependency updates on top of the restored state: - vite: ^6.3.1 → ^8.1.2 (keeping master's security bumps) - @vitejs/plugin-react: ^4.2.0 → ^6.0.5 (Vite 8 peer requirement) - vitest: ^1.3.0 → ^4.1.11 (Vite 8 compatibility + critical CVE fix) - remove @eslint/css (not used in the TypeScript eslint config) Two moderate react-router CVEs remain; fixing them requires upgrading to react-router-dom v7, which is a breaking API change — separate follow-up. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WtwNJovJbV7nc3LSWHisHB
Replaces __dirname with import.meta.dirname, which Vite 8 recommends when using the native config loader. tsconfig.node.json already uses moduleResolution: bundler which supports import.meta.dirname. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WtwNJovJbV7nc3LSWHisHB
✅ Deploy Preview for geochicasosm-lascallesdelasmujeres ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
vite.config.ts reads VITE_BASE_PATH env var at build time (defaults to /lascallesdelasmujeres/ for GitHub Pages). BrowserRouter basename is driven by import.meta.env.BASE_URL so it can never drift from the asset paths. netlify.toml sets VITE_BASE_PATH=/ and adds a /* -> /index.html 200-rewrite so deep links work on Netlify previews. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WtwNJovJbV7nc3LSWHisHB
Collaborator
Author
|
@jsanz @fpsampayo podriais echar un ojo antes de hacer el merge esta vez? Gracias! |
jessisena
marked this pull request as ready for review
August 18, 2026 21:43
Collaborator
|
@clds1 @mapanauta podéis echarle un vistazo al preview de la actualización de la web y darnos vuestro OK? Fijaros en las diferencias y en la nueva página con estadísticas. Tal vez mejor hacer esto en un ordenador, no desde el móvil que será más complicado de comparar con la web en producción. Preview: https://deploy-preview-115--geochicasosm-lascallesdelasmujeres.netlify.app/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recuperados cambios de #92 y #93 , anadido fix en el routing para github pages y netlify