Skip to content

Conversation

@norkunas
Copy link
Member

@norkunas norkunas commented Dec 17, 2025

Summary by CodeRabbit

  • Chores
    • Removed deprecated code from the validation component to improve code maintainability.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Dec 17, 2025

Walkthrough

The pull request removes the deprecated $errorNames static property and its associated docblock from the Address constraint class, with no functional changes to the codebase.

Changes

Cohort / File(s) Summary
Constraint cleanup
src/Validator/Constraint/Address.php
Removed deprecated static property $errorNames and its docblock from the Address constraint class.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Straightforward removal of a deprecated static property
  • No logic changes or control flow modifications
  • Single file affected

Poem

🐰 A property once lived here, marked as old,
But time has come for cleanup bold,
$errorNames fades away with grace—
The Address class finds cleaner space!

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Remove deprecated Address::$errorNames' directly and clearly describes the main change: removal of the deprecated static property from the Address constraint class.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5bb8341 and cd6f97a.

📒 Files selected for processing (1)
  • src/Validator/Constraint/Address.php (0 hunks)
💤 Files with no reviewable changes (1)
  • src/Validator/Constraint/Address.php

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@norkunas norkunas merged commit bc3b1d9 into geocoder-php:master Dec 17, 2025
19 checks passed
@norkunas norkunas deleted the rm-deprecated-error-names branch December 17, 2025 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant