Skip to content

Fix keyUp when command is down #1324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

Kingminer7
Copy link
Contributor

Basically theres an issue where keyUp isn't called if command is down - this fixes that.

Only tested on intel, testing needed on m1

side note: not sure if this is 100% the way I should be hooking objc, lmk if its not

@altalk23
Copy link
Member

i can merge if you replace it with a ObjcHook::create hook

@altalk23
Copy link
Member

see the ShutdownFix.cpp for an example

@Kingminer7
Copy link
Contributor Author

i can merge if you replace it with a ObjcHook::create hook

tried to but couldn't get it to stop crashing on startup, seems to be whenever the function for the hook runs
https://gist.github.com/Kingminer7/0a4857328d3a8dcff336c788d71b8dfc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants