Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces some breaking changes:
Renames some functions in
utils.math:The change in name is both for clarity and, in the case of l2, to encourage the user to recognise that l2_norm and compare_l2_norm now return the true L2 norm, rather than the square of the L2 norm.
Modifies the parts of the code that used the old functions.
Removes the following unused functions:
Fixes a small, previously untested bug in
complete_basis()in the case where columns were not flipped in the RREF.