Workflow simplification#28
Open
JakeGimenes wants to merge 16 commits into
Open
Conversation
…ants; use real river_route in tests
…packaging dependency
Workflow simplification
gdeploy now reads a plain YAML config (yaml.safe_load) instead of executing a Python source file as config. Removes PythonConfigFile/PythonConfigPath/ _load_source, repairs the broken YAMLConfigFile, and adds YAMLConfigPath; DeployConfigFile/DeployConfigPath now subclass the YAML loaders. The Config wrapper and builder.py are unchanged (YAML loads into the same nested-dict shape). Computed values the .cfg format allowed (f-strings, variable reuse) must now be written as literals. Adds config.example.yaml template and loader tests; updates README, PLAN, and .gitignore. Touches the otherwise-frozen comfies loader by design (agreed clean break, no Python-config fallback). Verified: pytest 40 passed. Reviewed via writer-reviewer (correct/merge-ready; all actionable findings addressed). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Brings the .cfg->YAML deploy-config switch into main so it is included in the upstream PR (geoglows/geoglows_ecflow geoglows#28).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.