Skip to content

Conversation

@meagharty
Copy link

@meagharty meagharty commented Nov 8, 2024

Upgrades to phoenix_html to v4+ which moves HTML helpers to phoenix_html_helpers.

From phoenix_html changelog:

v4.0.0 (2023-12-19)

This version removes deprecated functionality and moved all HTML helpers to a separate library. HTML Helpers are no longer used in new apps from Phoenix v1.7. Older applications who wish to maintain compatibility, add {:phoenix_html_helpers, "~> 1.0"} to your mix.exs and then replace use Phoenix.HTML in your applications by:

import Phoenix.HTML
import Phoenix.HTML.Form
use PhoenixHTMLHelpers

@meagharty
Copy link
Author

@geolessel, do you have thoughts on this?

This patches the issue of the deprecation of Phoenix.HTML.Tag within phoenix_html, mentioned in #67, without requiring the addition of phoenix_live_view to this package at this time.

meagharty added a commit to mbta/react-phoenix that referenced this pull request Nov 20, 2024
…#1)

* deps: upgrade phoenix_html and add phoenix_html_helpers

* docs: update README code example with new imports for phoenix_html and phoenix_html_helpers
Copy link
Owner

@geolessel geolessel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I like this. Thank you. I'm going to try this in a project and if it works out, merge it and cut a new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants