-
Notifications
You must be signed in to change notification settings - Fork 7
added an endpoint without side effect #463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
57d67e6
added an endpoint without side effect
niryuu e04da30
(refs #463) removed duplicated changes regarding #466
niryuu efb3469
(refs #463) docs should be keeped
niryuu 546b906
(refs #463) cleanup event handlers when remove simplestyle
niryuu 885f950
(refs #463) fixed type definition
niryuu b25cccd
(refs #463) fixed race condition on webpack
niryuu ebe5fbf
(refs #463) fixed cursor state on remove
niryuu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| /** | ||
| * @file Side-effect-free entry point for programmatic use (e.g. React wrapper). | ||
| * Does NOT call renderGeoloniaMap() or set window.geolonia. | ||
| * Only registers the PMTiles protocol, which is required for all users. | ||
| */ | ||
|
|
||
| import maplibregl from 'maplibre-gl'; | ||
| import { Protocol } from 'pmtiles'; | ||
|
|
||
| // PMTiles protocol registration (required side effect) | ||
| const protocol = new Protocol(); | ||
| maplibregl.addProtocol('pmtiles', protocol.tile); | ||
|
|
||
| export { default as GeoloniaMap } from './lib/geolonia-map'; | ||
| export { default as GeoloniaMarker } from './lib/geolonia-marker'; | ||
| export { SimpleStyle } from './lib/simplestyle'; | ||
| export { default as SimpleStyleVector } from './lib/simplestyle-vector'; | ||
| export { keyring } from './lib/keyring'; | ||
| export { registerPlugin } from './lib/render'; | ||
| export { VERSION as embedVersion } from './version'; | ||
| export type { EmbedAttributes, EmbedPlugin } from './types'; | ||
| export type { GeoloniaMapOptions } from './lib/geolonia-map'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| import type GeoloniaMap from './lib/geolonia-map'; | ||
|
|
||
| export type EmbedAttributes = { | ||
| lat: string | number; | ||
| lng: string | number; | ||
| zoom: string | number; | ||
| bearing: string | number; | ||
| pitch: string | number; | ||
| hash: string; | ||
| marker: string; | ||
| markerColor: string; | ||
| openPopup: string; | ||
| customMarker: string; | ||
| customMarkerOffset: string; | ||
| gestureHandling: string; | ||
| navigationControl: string; | ||
| geolocateControl: string; | ||
| fullscreenControl: string; | ||
| scaleControl: string; | ||
| geoloniaControl: string; | ||
| geojson: string; | ||
| cluster: string; | ||
| clusterColor: string; | ||
| style: string; | ||
| lang: string; | ||
| plugin: string; | ||
| key: string; | ||
| apiUrl: string; | ||
| loader: string; | ||
| minZoom: string | number; | ||
| maxZoom: string | number; | ||
| '3d': string; | ||
| [otherKey: string]: string | number; | ||
| }; | ||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
|
|
||
| export type EmbedPlugin< | ||
| PluginAttributes extends { [otherKey: string]: string } = { | ||
| [otherKey: string]: string; | ||
| }, | ||
| > = ( | ||
| map: GeoloniaMap, | ||
| target: HTMLElement, | ||
| atts: EmbedAttributes & PluginAttributes, | ||
| ) => void; | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.