fix: E2Eテストが失敗する問題を修正#466
Conversation
* 存在しないファイルを参照していた問題を修正 * 実装されていないログをチェックしていた問題を修正
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 Walkthroughウォークスルーe2eテスト 変更内容
推定コードレビュー工数🎯 2 (Simple) | ⏱️ ~10分 ポエム
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Comment |
yuiseki
left a comment
There was a problem hiding this comment.
LGTM! Thank you for the fix.
I've confirmed that the two issues addressed here are valid:
external-style.htmlwas ine2e/but needed to be indocs/e2e/to be served by the dev server- The removed console message checks (
"API key not found","Loading external style from") were testing for logs that don't exist in the codebase
The replacement test using page.waitForRequest to verify the external style URL is a better approach.
Note: PR #463 also includes these same E2E fixes as part of a larger change. Once this PR is merged, it would be good to coordinate with @niryuu to rebase #463 on master so the duplicate changes are resolved cleanly.
Fixes #464
Summary
Checklist
Summary by CodeRabbit
リリースノート