ビルドせずにE2Eテストを実行した場合にExternal Style Support関連のテストが失敗する問題を修正#471
Merged
Conversation
📝 WalkthroughWalkthrough
Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@README.md`:
- Line 106: Remove the shell prompt prefix from the example command in
README.md: replace the line containing "$ npm run e2e" with the same command
without the leading "$" so it reads as the plain command (e.g., npm run e2e) to
satisfy markdownlint MD014 and avoid CI lint noise; just edit the README.md
entry that currently shows "$ npm run e2e".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #468
Summary
#468 について、対応案3で記載していた内容となります。
Checklist (optional)
npm run buildを実行していないとExternal Style Support関連のテストが失敗する #468 で記載の再現手順で、本対応後にE2Eテストでエラーが発生しなくなることを確認Summary by CodeRabbit
リリースノート