fix: .gitignore に embed-core 関連のビルド成果物を追加#472
Conversation
embed-core エントリポイント追加時に .gitignore の更新が漏れていた。 - /docs/embed-core.js, /docs/embed-core-chunks - /docs/e2e/*.d.ts, /docs/src/ (webpack が出力する型定義) - docs/embed-core.js.LICENSE.txt を追跡対象に追加 - docs/embed.js.LICENSE.txt の MapLibre バージョン参照を更新 (v4.7.1 → v5.7.0) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📝 Walkthrough概要
変更内容
推定コードレビュー時間🎯 1 (Trivial) | ⏱️ ~3 minutes 詩
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.gitignore:
- Line 76: Remove the stale /docs/embed-core-chunks entry from .gitignore
because both embedConfig and embedCoreConfig set chunkFilename:
path.join('embed-chunks', '[chunkhash].js') (in webpack.config.js), so runtime
chunks are emitted to /docs/embed-chunks; delete the duplicate
/docs/embed-core-chunks ignore line to avoid ignoring a non-existent path and
keep only the correct /docs/embed-chunks entry if present.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 081021ba-8e0f-49a9-9017-7e78ed48374c
📒 Files selected for processing (3)
.gitignoredocs/embed-core.js.LICENSE.txtdocs/embed.js.LICENSE.txt
webpack.config.js では embedConfig, embedCoreConfig ともに chunkFilename: 'embed-chunks/[chunkhash].js' を使用しているため、 embed-core-chunks ディレクトリは生成されない。 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Approveありがとうございます!マージします |
Summary
.gitignoreの更新が漏れていたのを修正docs/embed-core.js.LICENSE.txtを追跡対象に追加docs/embed.js.LICENSE.txtの MapLibre バージョン参照を更新 (v4.7.1 → v5.7.0).gitignore に追加したルール
/docs/embed-core.js/docs/embed-core-chunks/docs/e2e/*.d.ts/docs/src/Test plan
npm run buildでビルド成功npx playwright testで既存 21 テスト全パスgit statusでビルド成果物が untracked に出ないことを確認🤖 Generated with Claude Code