Skip to content

fix: .gitignore に embed-core 関連のビルド成果物を追加#472

Merged
yuiseki merged 2 commits into
masterfrom
fix/gitignore-embed-core
Mar 16, 2026
Merged

fix: .gitignore に embed-core 関連のビルド成果物を追加#472
yuiseki merged 2 commits into
masterfrom
fix/gitignore-embed-core

Conversation

@yuiseki

@yuiseki yuiseki commented Mar 16, 2026

Copy link
Copy Markdown
Member

Summary

  • embed-core エントリポイント追加(added an endpoint without side effect #463)時に .gitignore の更新が漏れていたのを修正
  • docs/embed-core.js.LICENSE.txt を追跡対象に追加
  • docs/embed.js.LICENSE.txt の MapLibre バージョン参照を更新 (v4.7.1 → v5.7.0)

.gitignore に追加したルール

パターン 理由
/docs/embed-core.js 新エントリポイントのビルド成果物
/docs/embed-core-chunks 新エントリポイントのチャンク
/docs/e2e/*.d.ts webpack が出力する E2E テストの型定義
/docs/src/ webpack が出力する src の型定義

Test plan

  • npm run build でビルド成功
  • npx playwright test で既存 21 テスト全パス
  • git status でビルド成果物が untracked に出ないことを確認

🤖 Generated with Claude Code

embed-core エントリポイント追加時に .gitignore の更新が漏れていた。
- /docs/embed-core.js, /docs/embed-core-chunks
- /docs/e2e/*.d.ts, /docs/src/ (webpack が出力する型定義)
- docs/embed-core.js.LICENSE.txt を追跡対象に追加
- docs/embed.js.LICENSE.txt の MapLibre バージョン参照を更新 (v4.7.1 → v5.7.0)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@yuiseki yuiseki self-assigned this Mar 16, 2026
@coderabbitai

coderabbitai Bot commented Mar 16, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@yuiseki has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 20 minutes and 46 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c4f35884-e9f3-4a31-beca-fdfe5c23b40d

📥 Commits

Reviewing files that changed from the base of the PR and between b1d72b0 and 4d04d1a.

📒 Files selected for processing (1)
  • .gitignore
📝 Walkthrough

概要

.gitignoreにビルドおよびドキュメント生成物の無視ルールが追加され、MapLibre GL JSのライセンスファイル2つが更新されました。コードロジックの変更はなく、ビルドアーティファクトとライセンス情報の管理に関連する変更です。

変更内容

コホート / ファイル 要約
ビルドアーティファクト無視ルール
.gitignore
生成されたファイルとディレクトリの無視パターンを追加。/docs/embed-core.js/docs/embed-core-chunks/docs/e2e/*.d.ts/docs/src/の4つのルールを追加。
ライセンスファイル
docs/embed-core.js.LICENSE.txt, docs/embed.js.LICENSE.txt
MapLibre GL JSのライセンスヘッダーを追加・更新。embed.jsのライセンスURLをv4.7.1からv5.7.0に更新。

推定コードレビュー時間

🎯 1 (Trivial) | ⏱️ ~3 minutes

🐰 ライセンスとルール整え、
生成物をそっと隠して、
ビルドの庭をきれいにした、
バージョンアップ祝う春、
整理整頓ウサギの日! 📄✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding embed-core related build artifacts to .gitignore as indicated by the PR objectives and file changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/gitignore-embed-core
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@yuiseki
yuiseki requested a review from bougan1160 March 16, 2026 03:06

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.gitignore:
- Line 76: Remove the stale /docs/embed-core-chunks entry from .gitignore
because both embedConfig and embedCoreConfig set chunkFilename:
path.join('embed-chunks', '[chunkhash].js') (in webpack.config.js), so runtime
chunks are emitted to /docs/embed-chunks; delete the duplicate
/docs/embed-core-chunks ignore line to avoid ignoring a non-existent path and
keep only the correct /docs/embed-chunks entry if present.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 081021ba-8e0f-49a9-9017-7e78ed48374c

📥 Commits

Reviewing files that changed from the base of the PR and between 3e62985 and b1d72b0.

📒 Files selected for processing (3)
  • .gitignore
  • docs/embed-core.js.LICENSE.txt
  • docs/embed.js.LICENSE.txt

Comment thread .gitignore Outdated
@yuiseki
yuiseki requested a review from madmaid March 16, 2026 03:11
webpack.config.js では embedConfig, embedCoreConfig ともに
chunkFilename: 'embed-chunks/[chunkhash].js' を使用しているため、
embed-core-chunks ディレクトリは生成されない。

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

@sanak sanak left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

こちら対応頂き、ありがとうございます!🙇

@yuiseki

yuiseki commented Mar 16, 2026

Copy link
Copy Markdown
Member Author

Approveありがとうございます!マージします

@yuiseki
yuiseki merged commit 8e7b4e6 into master Mar 16, 2026
10 checks passed
@yuiseki
yuiseki deleted the fix/gitignore-embed-core branch March 16, 2026 03:47
@yuiseki yuiseki mentioned this pull request Mar 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants