Add e2e test job to CI workflow#480
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughGitHub Actionsに新しい ChangesE2E CI integration
Estimated Code Review Effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/build.yml:
- Around line 67-73: The Upload Playwright report step currently uses the
conditional if: ${{ !cancelled() }} which prevents the artifact upload when a
run is cancelled; update the step named "Upload Playwright report" to use either
if: ${{ failure() || cancelled() }} to preserve artifacts for failures and
cancellations or if: ${{ always() }} to preserve artifacts in all outcomes
(success/failure/cancelled), ensuring the path: playwright-report/ still gets
uploaded and retention-days: 7 remains unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 6f6a8a23-3ae4-4c6c-8060-7eb7a40c8dea
📒 Files selected for processing (2)
.github/workflows/build.ymlplaywright.config.ts
|
確認頂き、ありがとうございます! |
Summary
build→e2e→publish/deployのジョブ依存関係を設定html→listに変更(HTML reporter は CI 上で対話モードに入りnpm run e2eが終了しないため)waitForStyleLoadを追加(attribution は TileJSON 取得後に埋まるので、canvas 出現待ちだけでは間に合わないため)Changes
master との累積 diff: 3 ファイル / +28 / −3 行。コミットはファイル境界に揃えて 3 本に整理。
.github/workflows/build.ymlecf8d06e2eジョブ追加 +publish/deployの依存関係更新playwright.config.tsc7d6223html→liste2e/basic.spec.ts865d171waitForStyleLoadを追加Details
npm run e2e)で実行時間を抑制timeout-minutes: 30でジョブのハング防止if: !cancelled())Test plan
npm run e2eが全 10 テスト通過を確認e2eジョブが正常に実行されることを確認(run #26066413337: build 59s + e2e 54s, ともに pass)Summary by CodeRabbit