feat: テナント匿名アクセス設定 & policies create ヘルプ改善#78
Merged
Conversation
…ate のヘルプに target スキーマ例を追加 - admin tenants update に --anonymous-access / --no-anonymous-access フラグを追加し、 テナントの anonymousAccessEnabled を CLI から直接切り替え可能にした (#76) - admin policies create のヘルプに target フィールド (subjects, resources, actions, environments) の構造と実用的な JSON 例を追加 (#75) - 匿名アクセスポリシーの作成例を policies create の examples に追加 - テナント update の --anonymous-access フラグに対するテスト4件を追加 Closes #75, Closes #76
- anonymousAccessEnabled を settings.features 配下のネスト構造に修正 (トップレベルではなく settings.features.anonymousAccessEnabled) - policy target から environments フィールドを削除（サーバー未サポート） - action の attributeId を "action" から "method" (HTTP method) に修正 - target の matchFunction オプション (string-equal, string-regexp, glob) を記載 - subjects/resources/actions の有効な attributeId 一覧をヘルプに追加
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughテナントの匿名アクセス設定を管理するための CLI フラグ Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~15 minutes Poem
🚥 Pre-merge checks | ✅ 5 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
admin tenants updateに--anonymous-access/--no-anonymous-accessオプションを追加し、テナントの匿名アクセス (settings.features.anonymousAccessEnabled) を CLI から切り替え可能にしたadmin policies createのヘルプにtargetフィールドのスキーマ例・有効なattributeId一覧・matchFunctionオプションを追加Details
#76: テナント匿名アクセス設定
settings.features.anonymousAccessEnabled) に準拠#75: policies create ヘルプ改善
targetフィールド付きの実用的な JSON 例を追加subjects,resources,actionsattributeIdを一覧表示matchFunction(string-equal,string-regexp,glob) を記載Test plan
admin tenants update --anonymous-accessが{ settings: { features: { anonymousAccessEnabled: true } } }を PATCHadmin tenants update --no-anonymous-accessがfalseを PATCHCloses #75, Closes #76
Summary by CodeRabbit
新機能
admin tenants updateコマンドに--anonymous-access/--no-anonymous-accessフラグを追加しました。ドキュメント
admin policies createコマンドのヘルプにスキーマ例を追加。targetフィールドの詳細説明とペイロード例が充実しました。