Skip to content

fix(ci): remove npm@latest from publish workflow#99

Merged
miya0001 merged 4 commits into
mainfrom
fix/publish-workflow
Apr 5, 2026
Merged

fix(ci): remove npm@latest from publish workflow#99
miya0001 merged 4 commits into
mainfrom
fix/publish-workflow

Conversation

@miya0001

@miya0001 miya0001 commented Apr 5, 2026

Copy link
Copy Markdown
Member

Summary

  • publish ワークフローから npm install -g npm@latest を削除
  • Node.js 22.22.2 ランナーにバンドルされた npm と npm@latest の間で Cannot find module 'promise-retry' エラーが発生し、v0.10.1 リリースが失敗していた
  • actions/setup-node@v4 が互換性のある npm を既にセットアップしているため、このステップは不要

Test plan

  • CI が通ることを確認
  • マージ後、v0.10.1 タグを再作成して publish が成功することを確認

Summary by CodeRabbit

リリースノート

  • Chores
    • 公開パイプラインからのグローバル npm アップグレード手順を削除しました(CI ワークフローの軽微な最適化)。
    • バージョン 0.10.1 の変更履歴日付を更新し、CI 変更を追記しました。

miya0001 added 2 commits April 6, 2026 00:13
Node.js 22.22.2 runner has a dependency conflict with npm@latest,
causing `Cannot find module 'promise-retry'` error.
The step is unnecessary as actions/setup-node@v4 already provides
a compatible npm version.
@coderabbitai

coderabbitai Bot commented Apr 5, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b50d0243-2b74-45c4-ad34-84d5e7f24f46

📥 Commits

Reviewing files that changed from the base of the PR and between 52e129c and a0c7012.

📒 Files selected for processing (1)
  • CHANGELOG.md
✅ Files skipped from review due to trivial changes (1)
  • CHANGELOG.md

📝 Walkthrough

Walkthrough

publishジョブからnpm install -g npm@latestステップを削除し、残りの依存インストール、ビルド、公開手順は順序・ロジックを維持したままです。CHANGELOGにこのCI関連変更を記録しました。

変更内容

Cohort / File(s) Summary
CI/CDワークフロー
.github/workflows/publish.yml
publishジョブからグローバル npm アップグレード(npm install -g npm@latest)ステップを削除。後続のnpm install、ビルド、npm publish --provenance等の手順は変更なし。
ドキュメント
CHANGELOG.md
バージョン0.10.1配下に新しい日付セクション(2026-04-06)を追加し、publishワークフローからnpmアップグレード削除を記録。

コード審査工数の見積もり

🎯 1 (Trivial) | ⏱️ ~3 minutes

ポエム

🐰✨ 流れ一行、ふわり消えて、
npmの帽子そっと脱ぎ、
ビルドはそのまま律儀に進む、
日付刻まれたCHANGELOGの頁、
うさぎはぴょんと祝福する。 🎉

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically summarizes the main change: removing npm@latest from the publish workflow, which directly addresses the CI issue described in the PR objectives.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/publish-workflow

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@CHANGELOG.md`:
- Around line 12-14: The CHANGELOG has a chronological mismatch: the date group
heading "### 2026-04-06" sits under the released section "## [0.10.1] -
2026-04-05"; either move the "### 2026-04-06" entry (and its bullet) up into the
"## [Unreleased]" section as a date group, or update the "## [0.10.1] -
2026-04-05" header to the actual release date to restore chronological order;
locate and edit the headings "## [0.10.1] - 2026-04-05" and "### 2026-04-06" to
perform the chosen fix and ensure the file follows the Keep a Changelog format
(Japanese) with proper version/date grouping and PR suffixes.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0cfda35d-d38e-4f5d-b2d3-861ee5d7b25e

📥 Commits

Reviewing files that changed from the base of the PR and between 96ede30 and 52e129c.

📒 Files selected for processing (2)
  • .github/workflows/publish.yml
  • CHANGELOG.md
💤 Files with no reviewable changes (1)
  • .github/workflows/publish.yml

Comment thread CHANGELOG.md
@miya0001
miya0001 merged commit 3e62c2a into main Apr 5, 2026
11 of 13 checks passed
@miya0001
miya0001 deleted the fix/publish-workflow branch April 5, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant