[Initial condition] Add functions to initialize velocity and accelerations#105
Draft
bodhinandach wants to merge 2 commits intomasterfrom
Draft
[Initial condition] Add functions to initialize velocity and accelerations#105bodhinandach wants to merge 2 commits intomasterfrom
bodhinandach wants to merge 2 commits intomasterfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #105 +/- ##
==========================================
- Coverage 95.73% 95.60% -0.13%
==========================================
Files 244 244
Lines 51323 51410 +87
==========================================
+ Hits 49130 49146 +16
- Misses 2193 2264 +71 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
We should discuss input format for MP properties: Some of our MP input files have ID while others do not (see recently-added wiki page).
Similarly input consistency notes:
The current PR has elements from different types (ID and no header like volumes and cells, but multiline input in JSON like stresses). |
LDTalbot
requested changes
Jun 20, 2025
Collaborator
LDTalbot
left a comment
There was a problem hiding this comment.
#TODO
- Tests
- Particle sets option (if we keep 2-line JSON input format)
NOTES:
- We can alter volumes to use "read_particles_scalar_properties" in this PR (removing "read_particles_volumes")
- Should make separate PR for other proposed breaking changes re: particle input format consistency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the PR
This PR introduces a way to initialize the velocity and acceleration fields. To specify the inputs correctly, users need to specify the following in the .json file:
or
The .txt files should be located in the same working folder with input formats as follows for 3D:
For 2D, only three columns are necessary:
id,vx/ax,vy/ayRelated Issues/PRs
N/A
Additional context
N/A