David/refactor units #42
Conversation
| mnemonics = [] | ||
| for axis in axes: | ||
| for trace in axis.get_traces(): | ||
| mnemonics.append(trace.get_mnemonic()) | ||
| self.pop_axes( | ||
| *mnemonics, strict_index=False, exclude=kwargs.get("exclude", None) | ||
| ) | ||
| self.add_axes(*axes, **kwargs) |
There was a problem hiding this comment.
el formateo tiene mal gusto? Este me parece raro creo que hay un problema con github
pozo/units/__init__.py
Outdated
| import pint | ||
| from IPython.display import HTML, display | ||
|
|
||
| from .registry_config import registry_defines, registry_mapping |
There was a problem hiding this comment.
estilo nodejs, yo todavia prefiero el namespace
from . import registry_config
registry_config.registry_defines()
registry_config.registry_mapping()
# o mejor
registry_config.init_defines()
registry_config.init_mapping()
pozo/units/__init__.py
Outdated
| red_low = re.compile(r'<td>(.+)?(?:LOW|NONE)(.+)?</td>') | ||
| orange_medium = re.compile(r'<td>(.+)?MEDIUM(.+)?</td>') | ||
|
|
||
| def check_las(las, registry=registry, HTML_out=True, divid=""): |
There was a problem hiding this comment.
def check_las(las, registry=registry, *, HTML=True, div_id=""):
no recuerdo por que tengo HTML_out=True/False?
There was a problem hiding this comment.
Por esto:
result = [delimiter.join(col_names)] if HTML_out else []
| self._mnemonic_to_units = {} | ||
| self._units_to_mnemonic = {} | ||
|
|
||
| def register_mapping(self, mnemonic, unit, ranges): |
There was a problem hiding this comment.
necesito tipos y tambien documentación para entender lo que hice
|
|
||
| self._mnemonic_to_units[mnemonic][unit] = ranges | ||
|
|
||
| for ra in ranges: |
| if mnemonic not in self._mnemonic_to_units: | ||
| self._mnemonic_to_units[mnemonic] = {} | ||
| self._units_to_mnemonic[mnemonic] = {} |
| # Or would we just use a default registery like in init | ||
| class LasRegistry(pint.UnitRegistry): | ||
| # Or would we just use a default register like in init | ||
| class LasUnitRegistry(pint.UnitRegistry): |
There was a problem hiding this comment.
no es posible quitarnos de esta clase de alguna forma?
There was a problem hiding this comment.
y también proveer una api bien simplificada
| "lasio" | ||
| ] | ||
| "lasio", | ||
| "anywidget>=0.9.18", |
There was a problem hiding this comment.
creo que ipywidgets y anywidgets estan.... juntos, tal vez
anywidget tiene ipywidget o al reves
2 participants
No description provided.