Skip to content

David/fix ruff exceptions #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: david/refactor-units
Choose a base branch
from
Open

David/fix ruff exceptions #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bbd00cc
Fix ruff codes E402 and F403 module imports
davidangarita1 Jun 4, 2025
5378ea3
Remove repeated "LLD" in dictionary
davidangarita1 Jun 4, 2025
0007dcf
Fix ruff exception E721
davidangarita1 Jun 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pozo/drawable.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

class VersionedProperty:
def __set_name__(self, owner, name):
if type(owner) == str(Drawable):
if not issubclass(owner, Drawable):
raise AttributeError(f"{name} must be a member of a class inheriting pozo.drawable.Drawable, not {owner}. Is type {type(owner)}.")
self._private_name = "_" + name
self._name = name
Expand Down
8 changes: 5 additions & 3 deletions pozo/themes/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,11 @@
import copy
import colour
import json
from IPython.display import display, HTML

import colour
from IPython.display import HTML, display

import pozo.themes.mnemonic_tables as tables
from pozo.themes.theme_tools import ColorWheel, MnemonicDictionary, default_theme

ThemeValues = dict(color="Can be a single color value or list of color values from colour package",
track_width="A number in pixels",
Expand Down Expand Up @@ -108,7 +111,6 @@ def get_theme(self):
return self._get_theme()

# Above are inheritables
from pozo.themes.theme_tools import * # should it be relative?
# Below is implementations
themes = {'cangrejo': MnemonicDictionary(tables.cangrejo)}
cangrejo = MnemonicDictionary(tables.cangrejo)
Expand Down
12 changes: 0 additions & 12 deletions pozo/themes/mnemonic_tables.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,18 +32,6 @@
"scale": "log",
"range_unit": "ohm * meter",
},
"LLD" : {
"color" : "red",
"range": [0.2, 2000],
"scale": "log",
"range_unit": "ohm * meter",
},
"LLD" : {
"color" : "red",
"range": [0.2, 2000],
"scale": "log",
"range_unit": "ohm * meter",
},
"LLD" : {
"color" : "red",
"range": [0.2, 2000],
Expand Down
Loading