add jspark locally #448
Merged
add jspark locally #448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI CI failures are unrelated and likely due to Python 3.7 support. @justb4 perhaps we should update to Python 3.8+ (in another PR)? |
|
CI failures are flake8 deps related it looks like: PyCQA/flake8#1701 You may try in |
|
Even in pygeoapi we still use Python 3.7 in CI... |
|
Do we have a 3.7 requirement for GHC? |
|
Looks like a different unrelated CI error. |
|
Not really but the Docker Image venv also runs Python 3.7. |
|
Suggest we merge this PR and have a future/sprint activity to upgrade to 3.8+? |
|
But we are much further: CI error is related to changed URL in unit test. I can repare. |
|
Yes, ok 3.8 in next sprint. Will issue PR to fix unit tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.