Skip to content

Extending the WFS-Probe request to handle the count parameter. #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nollpa wants to merge 5 commits into from
Closed

Extending the WFS-Probe request to handle the count parameter. #469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
743252d
Extending the WFS-Probe request to handle the count parameter.
Apr 9, 2024
adfaa43
set maxfeature instead of count parameter, to be compatible with WFS …
Apr 10, 2024
d06aadd
set default value for maxfeatures to 5.
Apr 10, 2024
a968b10
set max_count to required:False and insert max_count in resources.jso…
Apr 11, 2024
f91cba1
Fix a typo. Added max_count to fixtures.json and resources.json
Apr 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion GeoHealthCheck/plugins/probe/wfs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ class WfsGetFeatureBbox(Probe):
xsi:schemaLocation="http://www.opengis.net/wfs
http://schemas.opengis.net/wfs/1.1.0/wfs.xsd"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
<wfs:Query typeName="{type_name}" srsName="{srs}"
<wfs:Query typeName="{type_name}" srsName="{srs}" maxFeatures="{max_count}"
xmlns:{type_ns_prefix}="{type_ns_uri}">
<ogc:Filter xmlns:ogc="http://www.opengis.net/ogc">
<ogc:BBOX>
Expand Down Expand Up @@ -77,6 +77,13 @@ class WfsGetFeatureBbox(Probe):
'required': True,
'range': None
},
'max_count': {
'type': 'string',
'description': 'Maximum amount of features to select',
'default': '5',
'required': True,
'range': None
},
'bbox': {
'type': 'bbox',
'description': 'The tile image extension',
Expand Down
2 changes: 2 additions & 0 deletions tests/data/fixtures.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,7 @@
"type_ns_prefix": "bag",
"type_ns_uri": "http://bag.geonovum.nl",
"srs": "EPSG:28992",
"max_count": "1",
"bbox": ["180635", "455870", "180961", "456050"]
}
},
Expand All @@ -189,6 +190,7 @@
"type_ns_prefix": "bag",
"type_ns_uri": "http://bag.geonovum.nl",
"srs": "EPSG:28992",
"max_count": "1",
"bbox": ["180635", "455870", "180961", "456050"]
}
},
Expand Down
2 changes: 2 additions & 0 deletions tests/data/resources.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,7 @@
"type_ns_prefix": "bag",
"type_ns_uri": "http://bag.geonovum.nl",
"srs": "EPSG:28992",
"max_count": "1",
"bbox": ["180635", "455870", "180961", "456050"]
}
},
Expand All @@ -198,6 +199,7 @@
"type_ns_prefix": "bag",
"type_ns_uri": "http://bag.geonovum.nl",
"srs": "EPSG:28992",
"max_count": "1",
"bbox": ["180635", "455870", "180961", "456050"]
}
},
Expand Down