Bugfix #68 (#105) add missing cql2 text predicates #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for NOT ... BETWEEN, IN, LIKE for cql2_text
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #68 and related to #105
Lark grammar for
NOT...IN,NOT...BETWEEN, andNOT...LIKEwere missing forcql2_text, although the parsing functions exist.This also adds equivalent tests for
cql2_textparsing ascql2_jsonparsing, including new tests for the 3 above. These threeNOTtests are not added to thecql2_jsontests as the structure is different for jsonNOT, and I'm unsure exactly how best to resolve that.All new tests are passing.