Skip to content

Conversation

@landryb
Copy link
Member

@landryb landryb commented Mar 13, 2025

geOrchestra/geonetwork checklist
cf geonetwork/core-geonetwork#8693

it might also be needed on 4.4, dont have an instance to test, but to check one can do

select * from metadatastatus where metadataid not in (select id from metadata);

if there's some records, then that's leftovers from deleted metadatas.

  • PR only involves cherry-picked commits from upstream.
  • PR contains custom code which will soon be available in an upstream release and can be overriden => mention core-geonetwork version if possible.
  • PR contains custom geOrchestra code, which need to be verified during future migrations.

@landryb landryb requested a review from f-necas March 13, 2025 16:13
@f-necas f-necas requested a review from pmauduit April 2, 2025 13:18
@landryb landryb mentioned this pull request Apr 28, 2025
4 tasks
Copy link
Member

@pmauduit pmauduit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not that much to review here, missing a bit the context, but reading the upstream issue, that looks fine.

I don't get why all this is not managed by the JPA shenanigans, I'd have expected that as long as we have dependencies defined in the (Java) object model, then removing a md would also cleanup underlying objects, but as long as the other objects are removed by hand 2 lines above the modification, fine then.

@pmauduit pmauduit merged commit 8fd99e8 into georchestra:georchestra-gn4.2.x-24.0 Apr 28, 2025
1 check passed
@pmauduit pmauduit deleted the fix/deletemdstatus branch April 28, 2025 09:57
@landryb
Copy link
Member Author

landryb commented Apr 28, 2025

thanks ! i guess i'll have to forward-port it to #321 ? since it hasnt been merged upstream yet..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants