Repository navigation
feat: render nodeSelector in the housekeeping clean-harvester-logs cronjob - #241
Merged
Merged
Conversation
…onjob Follows the pattern used by the fix-permissions-pvc cronjob: merges the global georchestra.nodeSelector values into the job pod spec, so the cronjob can be pinned to the same nodes as the rest of the instance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
geonetwork/housekeeping/clean-harvester-logsCronJob rendershousekeeping.tolerationsbut nonodeSelector, so unlike the rest of the instance it cannot be pinned to the nodes selected via the globalgeorchestra.nodeSelectorvalue (in our setup the geOrchestra nodes are tainted, and the job drifted onto non-geOrchestra workers).This mirrors the pattern already used by
extra/cronjob-fix-permissions-pvc.yaml:With
georchestra.nodeSelectoralready set in our values, the cronjob lands on the same nodes as the other webapps with no further configuration.Second commit bumps the chart version to 1.20.0.
Testing
helm lintcleanhelm templatewith values settinggeorchestra.nodeSelector: {app: georchestra}renders the selector into the job pod speckubectl create --dry-run=clientschema validation