Repository navigation
chore: cleaning up (unused?) variables, using the generated secret for sensitive ones (fixes #235) - #243
Conversation
…r sensitive ones (fixes #235)
There was a problem hiding this comment.
Thanks for moving the credentials out of plain value: entries, that's a good direction. Two issues block merging though (details inline):
- Backend pods won't start: the
envFrom.secretRefatbackend-deployment.yaml:115-117still references{{ fullname }}-backend, which no longer exists after the rename. Since it isn'toptional, pods end up inCreateContainerConfigError(confirmed withhelm template). secretKey/encryptionKeyare used: they reach the container asSECRET_KEY/ENCRYPTION_KEYthrough that sameenvFrom, and the backend reads both (georchestra/datafeederapps/backend/src/core/config.py).
Also:
datafeeder-python/Chart.yamlversion isn't bumped (still0.1.6).
* reverting back with secretKey/encryptionKey which are actually injected via envFrom * removing guards from secret templates * removing redundant references to secret * bumping chart version
edevosc2c
left a comment
There was a problem hiding this comment.
Thanks, LGTM!
Optional nit: setting one of these values to null makes rendering fail with a cryptic backend-secret.yaml:11:44 error. Using required would give a clearer message, e.g.:
SECRET_KEY: {{ required "backend.config.secretKey is required" $webapp.config.secretKey | b64enc | quote }}|
Thanks for adding |
I could not manage to figure out why, but the lint-test does not set up chart dependencies, so the check cannot pass. If you have any idea why Seems to relate to: helm/chart-testing-action#85 (comment) |
|
Yes, that's the issue: |
|
ok thanks for this |
A secret was already generated by the chart, but the data from it were not consumed by the underlying deployment.
Also grepping the chart, it looked like
secretKeyandencryptionKeyare not used.And I actually took the liberty to rename the secret, suffixing it with "-secret" to make it clear of what it is (and to distinguish from other objects).
Tests: very basic checks on the output of
helm template .