Repository navigation
feat: add extra_java_opts to the GeoNetwork Elasticsearch deployment - #245
Merged
Merged
Conversation
Elasticsearch ignores JAVA_TOOL_OPTIONS and _JAVA_OPTIONS (they are unset by bin/elasticsearch-env), so extra JVM options must go through ES_JAVA_OPTS, which is hardcoded in the template. The new extra_java_opts value is appended to it. Bump chart version to 1.22.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add an
extra_java_optsvalue to the GeoNetwork Elasticsearch deployment (georchestra.webapps.geonetwork.elasticsearch.extra_java_opts). It is appended to theES_JAVA_OPTSenvironment variable, after the built-in log4j options.Elasticsearch ignores
JAVA_TOOL_OPTIONSand_JAVA_OPTIONS(they are unset bybin/elasticsearch-env), soextra_environmentcannot be used to pass JVM options, andES_JAVA_OPTSwas hardcoded in the template.Changes
templates/geonetwork/elasticsearch/es-deployment.yaml: appendextra_java_optstoES_JAVA_OPTSvalues.yaml: addextra_java_opts: ""default for elasticsearch1.22.0, CHANGELOG updatedTesting
helm lint georchestrapasseshelm templatewithoutextra_java_opts:ES_JAVA_OPTSunchangedhelm templatewithextra_java_opts: options appended toES_JAVA_OPTS