Skip to content

Conversation

@edevosc2c
Copy link
Member

@edevosc2c edevosc2c commented Jul 4, 2024

  • Switch container port name from http-proxy to http: http-proxy word is confusing, it's not an HTTP proxy.
  • Add healthcheck probes to components that didn't have it.
  • Stop using tcpCheck and instead use httpCheck for being 100% sure that the traffic can flow to the application.
  • When possible use the named container port for things like liveness, service and more. This allows to specify the application number port only once.
  • Remove case for old Kubernetes version in default ingress

TODO:

  • Need to make sure that all the probes won't affect the startup of all apps.
  • allow customization of liveness and startup probes

Copy link
Member

@jeanpommier jeanpommier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice job !

@edevosc2c edevosc2c marked this pull request as draft July 5, 2024 09:44
@edevosc2c edevosc2c added the enhancement New feature or request label Jul 9, 2024
@edevosc2c edevosc2c force-pushed the better-healthcheck branch from 2ad1769 to 925b9f3 Compare July 15, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants