Verify tls option #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Does it impact the config file potentially ? If so, the option should be documented. |
arnaud-morvan
approved these changes
Mar 20, 2025
Contributor
arnaud-morvan
left a comment
arnaud-morvan
left a comment
There was a problem hiding this comment.
Looks good, minor comments.
|
|
||
| __Nota__: | ||
|
|
||
| At each level where login/password are specified, one can add the option `verify: false` to deactivate verification of HTTPS certificates. By default the HTTPS certificate must be valid, which is equivalent to `verify: true` |
Contributor
There was a problem hiding this comment.
I do not see verify in substitute_single_credentials_from
So it seems not possible to define verify with credentials at common (parent) level.
Maybe I miss something.
I would add in doc that this should only be used for development purpose as credentials will we sent unencrypted on the network.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possibility to configure the dev options for unverified certificates provided by the python GN ans GS libs