Skip to content

Conversation

@f-necas
Copy link
Contributor

@f-necas f-necas commented Dec 23, 2024

No description provided.

@landryb
Copy link
Member

landryb commented Dec 26, 2024

i had a closer look, and you drop the IgnoreIFrame param bit that was added in #155, im not fully sure to understand what it was supposed to achieve.. my guess would be embedding a context as a iframe in a page shouldn't include the header, be it as the legacy header iframe, or the newer web-component header ? in that case, is this behaviour preserved ?

I havent found other occurences in the code besides tests (https://github.com/search?q=repo%3Ageorchestra%2Fmapstore2-georchestra%20ignoreIFrame&type=code) so i'm .. puzzled.

@f-necas f-necas merged commit 8000aa0 into master Jan 23, 2025
2 checks passed
@f-necas f-necas deleted the header-config-file branch January 23, 2025 15:03
@github-actions
Copy link

github-actions bot commented Jul 3, 2025

💚 All backports created successfully

Status Branch Result
2024.02.xx

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

f-necas added a commit that referenced this pull request Jul 3, 2025
[2024.02.xx] Merge pull request #726 from georchestra/header-config-file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants