Skip to content

analyticsv2#2

Open
f-necas wants to merge 6 commits intomainfrom
analyticsv2
Open

analyticsv2#2
f-necas wants to merge 6 commits intomainfrom
analyticsv2

Conversation

@f-necas
Copy link
Contributor

@f-necas f-necas commented Mar 3, 2026

No description provided.

@f-necas f-necas marked this pull request as draft March 3, 2026 16:10
@f-necas f-necas requested a review from pmauduit March 24, 2026 14:25
@f-necas f-necas marked this pull request as ready for review March 24, 2026 14:25
@@ -0,0 +1,18 @@
Analytics container stops itself if it works correctly.

Needed to add in 100_analytics_init.sql:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as the lines have been added to the script, maybe it is not useful to duplicate the content here ? just mentioning the scripts which are setting up the db (under datadir/analytics/db.entrypoints.d/ ?)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we load the extensions into the georchestra database, why not having the scripts directly mounted under /docker-entrypoint.initdb.d, or injected by the dedicated dockerfile, to avoid one manual operation ?

# Publish in DB by batches
batch_size: 100

timezone: "Indian/Kerguelen"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it really be the default timezone ? :)


database:
drivername: "postgresql"
host: "localhost"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in a docker context, this is weird to read "localhost"

Comment on lines +16 to +34
sp_access_logs_filter:
# Accept only access logs from Security proxy
type: filter
inputs:
- opentelemetry.logs
condition:
type: "vrl"
source: '.scope.name == "org.georchestra.security-proxy.accesslog"'
# source: match!(.scope.name, r'org.georchestra.*.accesslog')

gw_access_logs_filter:
# Accept only access logs from Gateway
type: filter
inputs:
- opentelemetry.logs
condition:
type: "vrl"
source: '.scope.name == "org.georchestra.gateway.accesslog" '
# source: match!(.scope.name, r'org.georchestra.*.accesslog')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need both in this context ? maybe we could keep the sp_access_logs_filter commented out here, as we are using the gw

Comment on lines +106 to +108
"id": 'Geo2FranceDefault',
"description": '',
"label": 'Geo2France Default',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

specific to a customer

Comment on lines +34 to +37
# environment:
# - POSTGRES_DB=analytics
# - POSTGRES_USER=tsdb
# - POSTGRES_PASSWORD=password
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be removed, as they are defined in the env file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants