Skip to content

setValue calls onFinishChange by default #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
georgealways wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

setValue calls onFinishChange by default #162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
767cd05
setValue calls onFinishChange by default
georgealways Jul 20, 2025
d070a6d
fix for slider mousewheel onFinishChange
georgealways Jul 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/BooleanController.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ export default class BooleanController extends Controller {

this.$input.addEventListener( 'change', () => {
this.setValue( this.$input.checked );
this._callOnFinishChange();
} );

this.$disable = this.$input;
Expand Down
7 changes: 4 additions & 3 deletions src/Controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,6 @@ export default class Controller {
*/
reset() {
this.setValue( this.initialValue );
this._callOnFinishChange();
return this;
}

Expand Down Expand Up @@ -401,12 +400,15 @@ export default class Controller {
* @param {any} value
* @returns {this}
*/
setValue( value ) {
setValue( value, finishChange = true ) {

if ( this.getValue() !== value ) {

this.object[ this.property ] = value;
this._callOnChange();
if ( finishChange ) {
this._callOnFinishChange();
}
this.updateDisplay();

}
Expand All @@ -426,7 +428,6 @@ export default class Controller {

load( value ) {
this.setValue( value );
this._callOnFinishChange();
return this;
}

Expand Down
16 changes: 8 additions & 8 deletions src/NumberController.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ export default class NumberController extends Controller {
value = this._snap( value );
}

this.setValue( this._clamp( value ) );
this.setValue( this._clamp( value ), false );

};

Expand All @@ -108,7 +108,7 @@ export default class NumberController extends Controller {

if ( isNaN( value ) ) return;

this._snapClampSetValue( value + delta );
this._snapClampSetValue( value + delta, false );

// Force the input to updateDisplay when it's focused
this.$input.value = this.getValue();
Expand Down Expand Up @@ -202,7 +202,7 @@ export default class NumberController extends Controller {
dragDelta = this._min - initValue;
}

this._snapClampSetValue( initValue + dragDelta );
this._snapClampSetValue( initValue + dragDelta, false );

}

Expand All @@ -226,8 +226,8 @@ export default class NumberController extends Controller {

const onBlur = () => {
this._inputFocused = false;
this.updateDisplay();
this._callOnFinishChange();
this.updateDisplay();
};

this.$input.addEventListener( 'input', onInput );
Expand Down Expand Up @@ -267,7 +267,7 @@ export default class NumberController extends Controller {
const setValueFromX = clientX => {
const rect = this.$slider.getBoundingClientRect();
let value = map( clientX, rect.left, rect.right, this._min, this._max );
this._snapClampSetValue( value );
this._snapClampSetValue( value, false );
};

// Mouse drag
Expand Down Expand Up @@ -382,7 +382,7 @@ export default class NumberController extends Controller {

// set value
const delta = this._normalizeMouseWheel( e ) * this._step;
this._snapClampSetValue( this.getValue() + delta );
this._snapClampSetValue( this.getValue() + delta, false );

// force the input to updateDisplay when it's focused
this.$input.value = this.getValue();
Expand Down Expand Up @@ -498,8 +498,8 @@ export default class NumberController extends Controller {
return value;
}

_snapClampSetValue( value ) {
this.setValue( this._clamp( this._snap( value ) ) );
_snapClampSetValue( value, finishChange = true ) {
this.setValue( this._clamp( this._snap( value ) ), finishChange );
}

get _hasScrollBar() {
Expand Down
1 change: 0 additions & 1 deletion src/OptionController.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ export default class OptionController extends Controller {

this.$select.addEventListener( 'change', () => {
this.setValue( this._values[ this.$select.selectedIndex ] );
this._callOnFinishChange();
} );

this.$select.addEventListener( 'focus', () => {
Expand Down
2 changes: 1 addition & 1 deletion src/StringController.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ export default class StringController extends Controller {
this.$input.setAttribute( 'aria-labelledby', this.$name.id );

this.$input.addEventListener( 'input', () => {
this.setValue( this.$input.value );
this.setValue( this.$input.value, false );
} );

this.$input.addEventListener( 'keydown', e => {
Expand Down