Skip to content

Conversation

@leob
Copy link
Collaborator

@leob leob commented Dec 7, 2024

This PR is based on PR 36 - see the comment there:

#36 (comment)

So I pulled down the changes from PR 36, then merged it into a local branch from master and fixed the merge conflicts.
I then pushed that new local branch and created the PR from it.

Now let's see if the Github CI jobs work ... yes it looks okay now I think, I'm gonna merge this.

@leob leob self-assigned this Dec 7, 2024
@codecov
Copy link

codecov bot commented Dec 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.23%. Comparing base (0393ac5) to head (def1571).

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #37   +/-   ##
=========================================
  Coverage     38.23%   38.23%           
  Complexity       61       61           
=========================================
  Files             6        6           
  Lines           272      272           
=========================================
  Hits            104      104           
  Misses          168      168           
Flag Coverage Δ
pest-8.1 38.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leob leob merged commit 4c0108b into master Dec 7, 2024
8 of 12 checks passed
@leob leob mentioned this pull request Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants