feat(collection): condition + language visible where the copies live (E134)#1304
Merged
Conversation
…(E134) Condition and language were settable at add-time and condition is a filter facet, but no row at any density ever displayed them - a collector tracking LP/damaged copies had to open the edit dialog per card. - CardRow meta line gains deviation chips: LP/MP/HP/DMG (full word as title/aria) and non-English language names. Norms are unmarked - NM and English render nothing (imports stamp nm/en on nearly every copy; an always-on chip is noise). Chips follow CN's density rule (return >=768px in compact). - CardPreview compact header gains the language span beside the existing condition. - Symbol Key (collection + binder contexts - binder list rows render the same chips) gains 'Condition - Near Mint unmarked' with the four deviation chips. - STYLE_GUIDE: field budgets updated + detail-when-present / norms-unmarked ruling. Closes the Collection-UX program (E127-E134).
georgepapagapitos
enabled auto-merge (squash)
July 22, 2026 18:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes the Collection-UX program's last row (E127–E134). Condition + language were settable at add-time (PrintingPicker) and condition is a first-class filter facet, but no row at any density ever displayed them — a collector tracking LP/damaged copies had to open the edit dialog per card.
LP/MP/HP/DMG(full word as title + aria-label, labels from the exportedCONDITION_OPTIONS— no third label map) and non-English language names fromLANGUAGE_OPTIONS. Norms are unmarked: NM and English render nothing — the dev dataset showed imports stampnm/enon 11,527 of 11,531 copies, so an always-on chip is noise, not signal. Chips follow CN's density rule (drop <768px in compact, return ≥768px).Validation
Full gate green (typecheck, eslint+stylelint 0 errors, format, 6,783 tests — new coverage: chip render/absence incl. the NM-unmarked case, DMG abbreviation, language en-vs-ja, CardPreview condition backfill + language, Legend sections per context). Headless-Chromium as dev with seeded LP/DMG+ja/de copies: quiet rows at scale (no NM spam across 11.5k cards), deviation chips render (binder row shows
DMG Japanese), preview + Key verified, 360 DPR3 through 1024 light+dark.