Skip to content

Fix fill & cleanup BackEnd-Icons#2725

Open
xerc wants to merge 4 commits into
georgringer:mainfrom
xerc:patch-icons
Open

Fix fill & cleanup BackEnd-Icons#2725
xerc wants to merge 4 commits into
georgringer:mainfrom
xerc:patch-icons

Conversation

@xerc
Copy link
Copy Markdown
Contributor

@xerc xerc commented Nov 6, 2025

w/ fill
Bildschirmfoto 2025-11-06 um 16 59 53

@xerc
Copy link
Copy Markdown
Contributor Author

xerc commented Nov 6, 2025

fyi/ these are (still) shown via <img => <use -or- inline shadow-root would be prefered
Bildschirmfoto 2025-11-06 um 17 06 58

@lauralang
Copy link
Copy Markdown
Contributor

Hi, I just happened to come across this PR. In my opinion, it would make sense to also save the icons Icons/plugin-* with presentation attributes here in order to remove the inline CSS. This would directly solve the problem described in #2767. What do you think?

@xerc
Copy link
Copy Markdown
Contributor Author

xerc commented Jan 20, 2026

Hi, I just happened to come across this PR. In my opinion, it would make sense to also save the icons Icons/plugin-* with presentation attributes here in order to remove the inline CSS. This would directly solve the problem described in #2767. What do you think?

YES

fyi/ (vite) build scripts & EXT:sourceopt filter <style|defs> caused by ..
ref. https://stackoverflow.com/questions/39583880/external-svg-fails-to-apply-internal-css
ref. https://issues.chromium.org/issues/41337331#comment19 (might be fixed)

@lauralang
Copy link
Copy Markdown
Contributor

Using the export option Presentation Attributes would not include style tags.

Resources/Public/Icons/plugin-date-menu.svg exported with Presentation Attributes would look like this:
<svg xmlns="http://www.w3.org/2000/svg" width="96" height="96"><path fill="#fff" d="M0 0h96v96H0z"/><path fill="#7d83de" d="M0 0v96h96V0H0Zm90 90H6V6h84v84Z"/><path fill="#e84f35" d="M33 39h6v6h-6z"/><path fill="#7d83de" d="M21 33v30c0 3.6 2.4 6 6 6h42c3.6 0 6-2.4 6-6V33c0-3.6-2.4-6-6-6H27c-3.6 0-6 2.4-6 6Zm48 30H27V33h42v30Z"/><path fill="#7d83de" d="M45 39h6v6h-6zM57 39h6v6h-6zM33 51h6v6h-6zM45 51h6v6h-6zM57 51h6v6h-6zM39 27h-6v-4.8c0-.6.6-1.2 1.2-1.2h3.6c.6 0 1.2.6 1.2 1.2V27ZM63 27h-6v-4.8c0-.6.6-1.2 1.2-1.2h3.6c.6 0 1.2.6 1.2 1.2V27Z"/></svg>

@xerc
Copy link
Copy Markdown
Contributor Author

xerc commented Jan 20, 2026

Using the export option Presentation Attributes would not include style tags.

correct

Resources/Public/Icons/plugin-date-menu.svg exported with Presentation Attributes would look like this:
<svg xmlns="http://www.w3.org/2000/svg" width="96" height="96">

FIX ; <svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 96 96">

@georgringer
Copy link
Copy Markdown
Owner

ah sorry saw the PR too late, I updated some icons but would be great if you could recheck and update the PR if still needed! thanks

@xerc
Copy link
Copy Markdown
Contributor Author

xerc commented Jan 22, 2026

ah sorry saw the PR too late,[..] would be great if you could recheck and update the PR if still needed! thanks

yea.. manually removed id= & merged multi-lines (again)

@xerc
Copy link
Copy Markdown
Contributor Author

xerc commented Jan 22, 2026

want dark-mode LIST Icons/news_domain_model_* ?; #7d84df => currentColor
BUT they need to be included via <use @ recordlist-tx_news_domain_model_news

-OR- i can include inline CSS color-switch

@georgringer
Copy link
Copy Markdown
Owner

@xerc I can't really answer that tbh :( we can also discuss on slack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants