chore: restore earcut_impl as deprecated and document utils3d#45
Merged
ciscorn merged 1 commit intogeorust:mainfrom May 4, 2026
Merged
chore: restore earcut_impl as deprecated and document utils3d#45ciscorn merged 1 commit intogeorust:mainfrom
ciscorn merged 1 commit intogeorust:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Restores the previously-available earcut_impl entry point as a deprecated API while improving documentation around 3D→2D polygon projection helpers.
Changes:
- Added module/function-level rustdoc for
utils3dandproject3d_to_2d. - Refactored
Earcut::earcutto delegate to a new internalrunmethod. - Reintroduced
Earcut::earcut_implas a deprecated method calling the internalrun.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/utils3d.rs | Adds module + function documentation for the 3D-to-2D projection helper. |
| src/lib.rs | Reintroduces earcut_impl as deprecated and extracts shared logic into run. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #45 +/- ##
==========================================
- Coverage 99.72% 99.56% -0.17%
==========================================
Files 3 3
Lines 1851 1857 +6
==========================================
+ Hits 1846 1849 +3
- Misses 5 8 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGES.mdorCHANGELOG.md