Implement MonotoneChain data structure #1467
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- LineString where adjacent monotonic segments are grouped with a bounding box Implement Intersects for MontoneChain - large speedup on more complex geometries, but slower than base impl for simpler geometries Use MonotoneChain for large boundary intersections in ContainsProperly
Open
michaelkirk
reviewed
Dec 12, 2025
|
|
||
| impl<'a, T: GeoNum> From<&'a LineString<T>> for MonotoneChain<'a, T> { | ||
| fn from(linestring: &'a LineString<T>) -> Self { | ||
| // each segment is a a series of coordinates which are montonically increasing/decreasing |
Member
There was a problem hiding this comment.
Suggested change
| // each segment is a a series of coordinates which are montonically increasing/decreasing | |
| // each segment is a series of coordinates which are montonically increasing/decreasing |
| } | ||
|
|
||
| impl<'a, T: GeoNum> MonotoneChainSegment<'a, T> { | ||
| /// inclusive, exclusive |
Member
There was a problem hiding this comment.
This doc comment is pretty cryptic. Can you elaborate?
|
|
||
| Self { | ||
| ls: linestring, | ||
| bounding_rect: Rect::<T>::new(linestring[0], linestring[linestring.len() - 1]), |
Member
There was a problem hiding this comment.
If this is public, we should avoid panic, or at least document the panic condition in the case of LINESTRING EMPTY.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #1466
CHANGES.mdif knowledge of this change could be valuable to users.