Skip to content

Add failing test for issue iOverlay#27 (disconnected interiors) #1471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
bretttully wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add failing test for issue iOverlay#27 (disconnected interiors) #1471

bretttully wants to merge 1 commit into from

Conversation

@bretttully
Copy link

@bretttully bretttully commented Dec 8, 2025 •
edited by michaelkirk
Loading

Summary

Adds a failing test that documents iShape-Rust/iOverlay#27, where boolean operations can produce OGC-invalid polygons with disconnected interiors.

Test plan

  • The test creates a 5x5 box and subtracts two L-shaped holes that share vertices at (2,2) and (3,3)
  • This creates a polygon where the interior is disconnected, violating OGC Simple Feature Specification
  • The test asserts that the result should be split into 2+ polygons to maintain validity
  • Currently fails as expected - will pass once iOverlay fixes the upstream bug

Related Issues

🤖 Generated with Claude Code

@bretttully @claude
Add failing test for iOverlay issue georust#27 (disconnected interiors)
e36c4d5 
Boolean operations can produce OGC-invalid polygons when holes share
2+ vertices, creating disconnected interiors. This test documents the
issue and will pass once iOverlay fixes the upstream bug.

Fixes georust#1470

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>
@bretttully bretttully mentioned this pull request Dec 8, 2025
Open
@bretttully bretttully changed the title Add failing test for iOverlay issue #27 (disconnected interiors) Add failing test for issue iOverlay#27 (disconnected interiors) Dec 8, 2025
@michaelkirk michaelkirk marked this pull request as draft December 12, 2025 21:59
@michaelkirk
Copy link
Member

michaelkirk commented Dec 12, 2025

Thanks for the test!

I've converted this to a draft, since I don't think it makes sense to merge this until we get #1472 figured out.

My own preference is that you include this as a commit in #1472 - would that make sense to you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Boolean operations can produce OGC-invalid polygons with disconnected interiors

2 participants

@bretttully @michaelkirk