-
Notifications
You must be signed in to change notification settings - Fork 34
MAPL3 #530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
lizziel
wants to merge
11
commits into
dev/14.7.0
Choose a base branch
from
feature/mapl3
base: dev/14.7.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
MAPL3 #530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GEOS-Chem is not added as a gridded component and FV3 advection is not run. Enable by building with -DMODEL_CTMENV=y. A message is printed during configure stage if building with MODEL_CTMENV turned on. Otherwise, no message is printed. Signed-off-by: Lizzie Lundgren <[email protected]>
Signed-off-by: Lizzie Lundgren <[email protected]>
Signed-off-by: Lizzie Lundgren <[email protected]>
This update is temporary and removes all children. Signed-off-by: Lizzie Lundgren <[email protected]>
…dren Signed-off-by: Lizzie Lundgren <[email protected]>
pchakraborty
suggested changes
Dec 5, 2025
pchakraborty
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For interfaces of the registered methods (Initialize, Run, Finalize etc.) try
type(ESMF_GridComp):: gc ! composite gridded component
type(ESMF_State) :: import ! import state
type(ESMF_State) :: export ! export state
type(ESMF_Clock) :: clock ! the clock
integer, intent(out) :: rc ! Error code, 0 all is well, error otherwiseThe current GCHP_GridCompMod.F90 is a copy of mapl3_no_children. Signed-off-by: Lizzie Lundgren <[email protected]>
Signed-off-by: Lizzie Lundgren <[email protected]>
Contributor
Author
|
Thanks for the tip @pchakraborty! The model successfully builds and I'm now working through run-time errors. |
Signed-off-by: Lizzie Lundgren <[email protected]>
Signed-off-by: Lizzie Lundgren <[email protected]>
Signed-off-by: Lizzie Lundgren <[email protected]>
Signed-off-by: Lizzie Lundgren <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category: Feature Request
New feature or request
TODO: MAPL development
topic: Structural Modifications
Related to structural modifications (as opposed to scientific updates)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Lizzie Lundgren
Institution: Harvard University
Describe the update
This PR is a sandbox for MAPL3 changes. It should not be merged!
Expected changes
To be determined. MAPL3 is still in development.
Reference(s)
None
Related Github Issue
None