Multiphase aerosol chemistry (Travis et al., 2025)#4
Open
ktravis213 wants to merge 2 commits intogeoschem:geoschem/mainfrom
Open
Multiphase aerosol chemistry (Travis et al., 2025)#4ktravis213 wants to merge 2 commits intogeoschem:geoschem/mainfrom
ktravis213 wants to merge 2 commits intogeoschem:geoschem/mainfrom
Conversation
Add ionic strength diagnostic Signed-off-by: Katherine Travis <ktravis@fas.harvard.edu>
yantosca
requested changes
Jul 24, 2025
yantosca
left a comment
yantosca
left a comment
There was a problem hiding this comment.
Thanks @ktravis213, this looks good. Would you also be able to update the CHANGELOG.md file with a desccription of this update?
|
Also tagging @sdeastham, who is one of the HETP developers, as a heads-up. |
Author
|
Thanks @yantosca. There is not much in the changelog right now, so I am a little confused as to how to do it. Could we just add: "Addition of ionic strength diagnostic for use in the multiphase sulfate chemistry from Travis et al., 2025". |
Noted that an ionic strength diagnostic was added Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
yantosca
approved these changes
Mar 2, 2026
yantosca
left a comment
yantosca
left a comment
There was a problem hiding this comment.
Thanks @ktravis213. I updated the changelog and pushed the update back to your branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request allows for ionic strength to be passed from HETP to KPP. This is associated with the main PR geoschem/geos-chem#2966