-
Notifications
You must be signed in to change notification settings - Fork 439
#11577 Doc build fixed for node 22. Build strategy #11611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
|
Hey It looks great with testing different versions of node.js and java. I was thinking about making a similar suggestion, so its great to see that you got to the same conclusion. I however think it might be a bit excessive to also test the the Node 25. considering odd version numbers are only supported for 6 months, according to their documentation https://nodejs.org/en/about/previous-releases. Would it make sense to add a checkbox to the PR, so that the user can select frontend and/or backend. If I make a change to the frontend, it doesn't make sense to run backend test. The idea is to minimize the wait time for user, and lower the runtime spent on github. Final question, would it make sense to also make a test for windows, right not all test are running on ubuntu. |
|
hi @jna4k
Yes, I was still testing, thank you for the advice, I removed it.
I didn't see an option like this on github before. It could be cool. Anyway I see that all things here are done in parallel, so for the moment I don't see any bottleneck in testing everything. For now our tests take 10 minutes while deploy/publish 4m, and parallelism do not look to influence the build that much.
Here another PR still takes ~ 10 minutes.
Usually PRs are done to front-end, that takes most of the time for doing tests. So I think this improvement is not necessary at the moment. |
|
@tdipisa I kindly ask you to:
|
|
Ah, I didn't notice they were running in parallel, in that case everything looks good. |


Description
#11577 requires to make MapStore compatible with next versions on nodeJS.
Here in this PR I provide:
A strategy of build that tests on many versions, to have a clear idea of compatibility at every build, and the possibility to quickly add/remove versions to test.--> Setup CI with Matrix #11643Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
#11577
What is the new behavior?
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information